Document Module#delegate_missing_to in the guides #29268
Conversation
|
r? @matthewd (@rails-bot has picked a reviewer for you, use r? to override) |
|
|
| variables, methods, constants, etc. | ||
|
|
||
| WARNING: The delegated method calls must be public on the target, otherwise | ||
| they will raise `NoMethodError`. |
There was a problem hiding this comment.
This warning demonstrates that the behaviour doesn't match your manual implementation. 😉
Really though, I think the full method_missing/respond_to_missing? illustration is too much unnecessary detail. It works for delegate, but isn't an efficient use of space in general. Let's ditch it, and just focus on usage.
Maybe also consider reusing the User/Profile example... "or you could just forward everything" seems a logical leap from "here's how to delegate 4 methods in one line"
There was a problem hiding this comment.
Sure, I will try that! I :)
|
@matthewd I have condensed the example to the one above. Are you okay with it? |
gsamokovarov
force-pushed
the
delegate-missing-to-guides
branch
from
fb6d450
to
7ee6728
Compare
| #### `delegate_missing_to` | ||
|
|
||
| Imagine you would like to delegate all of the `Profile` methods to the `User` | ||
| object. Instead of listing every `Profile` method in a `delegate` call, you can |
There was a problem hiding this comment.
delegate all of the
Profilemethods to theUserobject
That sounds around the wrong way -- though the exact opposite isn't right either.
'to' -> 'from' might be sufficient?
There was a problem hiding this comment.
Updated it to:
Imagine you would like to delegate all methods from the
Profileto theUser
object...
Does it feel better now?
There was a problem hiding this comment.
No, because that still doesn't match what the code says: User.delegate_missing_to :profile
There was a problem hiding this comment.
So another take, this time trying to go with what the code says. 😅
Imagine you would like to delegate everything missing from the
Userobject,
to theProfileone. Thedelegate_missing_tomacro let's you implement this
in a breeze:
There was a problem hiding this comment.
☝🏻 looks good
("lets" not "let's")
gsamokovarov
force-pushed
the
delegate-missing-to-guides
branch
4 times, most recently
from
fa785fa
to
dced883
Compare
| The target can be anything callable within the object, e.g. instance variables, | ||
| methods, constants, etc. | ||
|
|
||
| NOTE: Defined in `active_support/core_ext/module/delegation.rb` |
There was a problem hiding this comment.
lgtm. We should mention only public methods are delegated.
There was a problem hiding this comment.
Just dropped it in a sentence. If you think a warning, like the one in #29268 (comment) works better, ping me and I'll change it.
Added a small section for it in the `Active Support Core Extensions` guide. [ci skip]
gsamokovarov
force-pushed
the
delegate-missing-to-guides
branch
from
dced883
to
43512df
Compare
Added a small section for it in the
Active Support Core Extensionsguide.