db:migrate:status not looking at all migration paths #2936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ths instead of only the apps db/migrate directory, which will include engine migrations.
spastorino
added a commit
that referenced
this pull request
Sep 12, 2011
db:migrate:status not looking at all migration paths
|
Thanks for the fix but please provide the pull requests for master next time |
spastorino
added a commit
that referenced
this pull request
Sep 12, 2011
db:migrate:status not looking at all migration paths
|
Apologies! |
|
No worries :), we should probably have some guidelines or something which states that more clear |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
db:migrate:status only looks in the app's db/migrate directory, which is no good for engines. It should use ActiveRecord::Migrator.migrations_paths instead.