Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Azure gems to README #30053

Merged
merged 4 commits into from Aug 3, 2017
Merged

Add Azure gems to README #30053

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8aa742f
Add Azure gems to README
Aug 2, 2017
0f2d3fb
Update README.md
Aug 3, 2017
d4f0b10
Use release azure-core gem
Aug 3, 2017
c5ae4e5
Tweak requires
Aug 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion activestorage/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,8 @@ Variation of image attachment:
1. Run `rails activestorage:install` to create needed directories, migrations, and configuration.
2. Optional: Add `gem "aws-sdk", "~> 2"` to your Gemfile if you want to use AWS S3.
3. Optional: Add `gem "google-cloud-storage", "~> 1.3"` to your Gemfile if you want to use Google Cloud Storage.
4. Optional: Add `gem "mini_magick"` to your Gemfile if you want to use variants.
4. Optional: Add `gem 'azure-core', git: "https://github.com/dixpac/azure-ruby-asm-core.git"` and `gem 'azure-storage', require: false` to your Gemfile if you want to use Microsoft Azure.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit: use double quotes to match the other optional steps.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, good point.

Also at some point presumably we can switch to the release version of the azure-core gem. I'm torn between wanting to note that or not, it's one more thing to keep track of for the future.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like @dixpac’s PR (Azure/azure-ruby-asm-core#39) was merged. @dixpac, can we switch back to the released gem now?

5. Optional: Add `gem "mini_magick"` to your Gemfile if you want to use variants.

## Direct uploads

Expand Down