Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return XMLHttpRequest instance from Rails.ajax() #30560

Closed
wants to merge 1 commit into from

Conversation

glaszig
Copy link
Contributor

@glaszig glaszig commented Sep 10, 2017

useful for, e.g., implementing autocomplete features and canceling requests:

xhr = null
autocomplete = ->
  xhr?.abort()
  xhr = Rails.ajax()
  # ...

document.querySelector('.autocompletable-field').addEventListener 'keypress', ->
  setTimeout autocomplete, 250

useful for, e.g., implementing autocomplete features
and canceling requests:

    xhr?.abort()
    xhr = Rails.ajax()
@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @eileencodes (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@eileencodes eileencodes removed their assignment Sep 20, 2017
@eileencodes
Copy link
Member

r? @javan

@javan
Copy link
Contributor

javan commented Sep 21, 2017

While this change seems reasonable, I don't think Rails.ajax was intended for public use. It's a private helper for remote forms. WDYT @guilleiguaran?

@javan javan assigned guilleiguaran and unassigned javan Oct 5, 2018
@glaszig
Copy link
Contributor Author

glaszig commented Dec 5, 2019

gonna close this. thanks for your consideration.

@glaszig glaszig closed this Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants