Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use webpack4 in ActiveStorage #32391

Closed
wants to merge 1 commit into from
Closed

Use webpack4 in ActiveStorage #32391

wants to merge 1 commit into from

Conversation

yhirano55
Copy link
Contributor

Summary

  • Upgraded webpack from 3 to 4. And installed webpack-cli to devDependencies.
  • Rebuild file through yarn build
  • Upgraded other dependencies (eslint ... and more)

@rails-bot
Copy link

r? @sgrif

(@rails-bot has picked a reviewer for you, use r? to override)

@yhirano55 yhirano55 force-pushed the use_webpack4_in_activestorage branch from 09b70e7 to d76c005 Compare April 2, 2018 23:53
@georgeclaghorn
Copy link
Contributor

r? @javan

@rails-bot rails-bot assigned javan and unassigned sgrif Apr 24, 2018
@javan javan mentioned this pull request Apr 25, 2018
Merged
@javan javan closed this in #32721 Apr 25, 2018
@javan
Copy link
Contributor

javan commented Apr 25, 2018

Thank you! Ended up ditching webpack entirely.

@yhirano55 yhirano55 deleted the use_webpack4_in_activestorage branch April 25, 2018 20:46
@yhirano55
Copy link
Contributor Author

I felt it's so nice approach to use rollup. Thanks for your works.

@yoyo-wu98 yoyo-wu98 mentioned this pull request Jul 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@javan javan

Labels
activestorage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yhirano55 @rails-bot @georgeclaghorn @javan @sgrif