[5-0-stable] Don't mutate parameters in test request helpers #32492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mutating the value passed as the `params` keyword argument when making a request in a controller test is surprising behaviour. We can avoid it by calling `symbolize_keys` first, which will make a copy of the hash. This matches the behaviour on 5.1 and later, which was introduced in 98b8309. On 4.2 and earlier, passing `format` separately wasn't supported, so this fix is only needed on 5.0.
|
r? @pixeltrix (@rails-bot has picked a reviewer for you, use r? to override) |
|
|
eugeneius
changed the title
|
@eugeneius thanks! 👍 |
bogdanvlviv
added a commit
to bogdanvlviv/rails
that referenced
this pull request
Apr 9, 2018
…utate_params` Use `#freeze` in order to express that params don't mutate. Related to rails#32492
bogdanvlviv
added a commit
to bogdanvlviv/rails
that referenced
this pull request
Apr 10, 2018
…master Initially, the test was added to 5-0-stable in rails#32492 and a bit modified in rails#32506. This test ensures that request(in tests) doesn't mutate params. It was fixed since v5.1.0.beta1 by 98b8309 and then on 5-0-stable by rails#32492. This commit adds this test to master branch in order to prevent any regressions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mutating the value passed as
paramswhen making a request in a controller test is surprising behaviour. We can avoid it by callingsymbolize_keysfirst, which will make a copy of the hash.This matches the behaviour on 5.1 and later, which was introduced in 98b8309. On 4.2 and earlier, passing
formatseparately wasn't supported, so this fix is only needed on 5.0.