Add migrations_paths option to migration generator #33760
Merged
+28
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an option to the migration generator to allow setting the
migrations paths for that migration. This is useful for applications
that use multiple databases and put migrations per database in their own
directories.
```
bin/rails g migration CreateHouses address:string --migrations-paths=db/kingston_migrate
invoke active_record
create db/kingston_migrate/20180830151055_create_houses.rb
```
eileencodes
deleted the
add-migrations_paths_option-to-migration-generator
branch
kamipo
reviewed
Aug 30, 2018
| @@ -24,7 +24,9 @@ def primary_key_type | |||
| end | |||
|
|
|||
| def db_migrate_path | |||
| if defined?(Rails.application) && Rails.application | |||
| if migrations_paths = options[:migrations_paths] | |||
There was a problem hiding this comment.
Is there any reason that named plural paths here even this db_migrate_path method returns a single path unlike other migrations_paths?
rails/activerecord/lib/active_record/migration.rb
Line 1183 in ec387c6
rails/activerecord/lib/active_record/tasks/database_tasks.rb
Lines 84 to 86 in cc81cd3
There was a problem hiding this comment.
Was just using the same name that's used everywhere else.
bogdanvlviv
added a commit
to bogdanvlviv/rails
that referenced
this pull request
Oct 15, 2018
…ors [ci skip] `migrations_paths` option was added to migration generator, with changelog entry, in rails#33760. Also `migrations_paths` option was added to model generator, with changelog entry, in rails#33994. Then `migrations_paths` was renamed to `database` and aliased as `db` in rails#34021, and was added new changelog entry. I think we should edit existed changelog entries instead adding new about changing the name of the option from `migrations_paths` to `database` since Rails 6.0 hasn't been released yet, and since It might confuse readers of the changelog file in case if they've read changelog enty about adding `migrations_paths` option but haven't read the entry about change the name of that option to `database`. @eileencodes, @gmcgibbon, @rafaelfranca Does it make sense?
suketa
added a commit
to suketa/rails_sandbox
that referenced
this pull request
Jun 9, 2019
* [Add migrations_paths option to migration generator](rails/rails#33760) * [Add migrations_paths option to model generator](rails/rails#33994) * [Refactor migrations_path command option to database](rails/rails#34021)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds an option to the migration generator to allow setting the
migrations paths for that migration. This is useful for applications
that use multiple databases and put migrations per database in their own
directories.