npmify Rails::VERSION for the package versions #34011
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @schneems (@rails-bot has picked a reviewer for you, use r? to override) |
|
|
matthewd
reviewed
Sep 28, 2018
| "rails-ujs": "~<%= npm_package_version %>"<% unless options[:skip_turbolinks] %>, | ||
| "turbolinks": "~5.1.1"<% end -%><% unless skip_active_storage? %>, | ||
| "activestorage": "~<%= npm_package_version %>"<% end -%><% unless options[:skip_action_cable] %>, | ||
| "actioncable": "~<%= npm_package_version %>"<% end -%> |
There was a problem hiding this comment.
Just a thought in passing, but it sounds like these conditionals could look much nicer if rails-ujs came last.
|
Addressed this with simply asking for anything newer than currently released for now in fbd4597. I'm not a fan of pessimistic dependency versioning, ESPECIALLY when those dependencies are exposed to easy editing by the application programmer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the versions in package.json based on the npm-ifed Rails::VERSION