Adds option extname to stylesheet_link_tag to exclude automatically appended .css extension
#41927
Conversation
There was a problem hiding this comment.
Testing this with <%= stylesheet_link_tag 'something.scss', extname: false, skip_pipeline: true %> seems to 404 when the browser fetches the scss. Using the pipeline raises a sprockets error Sprockets::Rails::Helper::AssetNotPrecompiled. I'm trying to clarify the use-case for this on the issue, I might be missing something.
There was a problem hiding this comment.
Please also add a changelog.
Regardless of the vite use-case, you can compile less in-browser officially with a JS library, so this makes sense to me. You would need to skip the pipeline though and service it from public though. Probably not a good idea for production, but I can see a reason to do it in development mode.
| @@ -138,6 +155,9 @@ def javascript_include_tag(*sources) | |||
| # stylesheet_link_tag "http://www.example.com/style.css" | |||
| # # => <link href="http://www.example.com/style.css" rel="stylesheet" /> | |||
| # | |||
| # stylesheet_link_tag "style.less", extname: false | |||
There was a problem hiding this comment.
I think
| # stylesheet_link_tag "style.less", extname: false | |
| # stylesheet_link_tag "style.less", extname: false, skip_pipeline: true, rel: "stylesheet/less" |
would be more correct. See Less' example: https://lesscss.org/, skip_pipeline: true may not be needed.
… appended `.css` extension. Fixes: rails#41918 This PR adds the option `extname` to `stylesheet_link_tag`. Previously, `stylesheet_link_tag` automatically added `.css`.
abhaynikam
force-pushed
the
41918-fix-stylesheet-link-tag-without-extname
branch
from
5528e83
to
2005afb
Compare
|
@gmcgibbon Thanks for taking look at the PR 😊 . Addressed all the suggestion and tested it locally. |
Fixes: #41918
This PR adds the option
extnametostylesheet_link_tag.Previously,
stylesheet_link_tagautomatically added.css.The change is similar to
javascript_include_tagwithextnameoption.