Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update karma npm from 3.1.4 to 6.4.2 #50018

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

tnir
Copy link
Contributor

@tnir tnir commented Nov 11, 2023

Motivation / Background

karma npm package, used in actioncable and actionview, has been stale.

karma 3.x was stable in 2018, but 6.x is now the latest.

This Pull Request has been created because Rails developers are to use the latest karma and latest Node.js (20 LTS or 21).

Detail

This Pull Request updates karma package from 3.1.4 to 6.4.2, which prevents from using chokidar@2 (or fsevents@1).

Additional information

The package was introduced in #34440 and #46206. Also this change follows up #49901 (Node.js 20).

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • [n/a] Tests are added or updated if you fix a bug or add a feature.
  • [n/a] CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

@p8
Copy link
Member

p8 commented Nov 18, 2023

Thanks @tnir for the PR!
This looks good to me.
The UJS test run fine: https://buildkite.com/rails/rails/builds/101823#018bbee0-2b70-408f-a450-31a35384d114

@p8 p8 added the ready PRs ready to merge label Nov 18, 2023
@tnir
Copy link
Contributor Author

tnir commented Nov 26, 2023

@p8 Thanks. Any help on this PR?

@p8
Copy link
Member

p8 commented Dec 17, 2023

@zzak @yahonda Is this good to go?

@zzak
Copy link
Member

zzak commented Dec 22, 2023

FWIW, I had looked at this back in #48041 but haven't followed up. Been meaning to look at updating yarn.lock but, yeah not sure yet. Thank you for investigating!

karma 3.x was stable in 2018, but 6.x is now the latest.

Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
@rafaelfranca rafaelfranca force-pushed the tn-update-karma-on-ac-av-testing branch from eb9320f to 3f635e3 Compare April 18, 2024 17:49
@rafaelfranca rafaelfranca merged commit b863551 into rails:main Apr 18, 2024
3 checks passed
@tnir tnir deleted the tn-update-karma-on-ac-av-testing branch May 14, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants