[ci skip] Update development_dependencies_install document for nodesource setup #49901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vipulnsward
reviewed
Nov 3, 2023
| # ref: https://github.com/nodesource/distributions#installation-instructions | ||
| $ sudo mkdir -p /etc/apt/keyrings | ||
| $ curl --fail --silent --show-error --location https://deb.nodesource.com/gpgkey/nodesource-repo.gpg.key | sudo gpg --dearmor -o /etc/apt/keyrings/nodesource.gpg | ||
| $ echo "deb [signed-by=/etc/apt/keyrings/nodesource.gpg] https://deb.nodesource.com/node_18.x nodistro main" | sudo tee /etc/apt/sources.list.d/nodesource.list |
There was a problem hiding this comment.
Lets update to 20 while we are here, current LTS - https://nodejs.org/en
There was a problem hiding this comment.
Thank you for your review.
I fixed it in d7396bfc20c3d20b5376fb2ece86c0b9694f76ca
|
@m11o Thanks for your patch! Could you please squash your commits? 🙇 |
…tall document. Because the traditional `setup_XX.x` script is deprecated, and there is a need to migrate to the new installation method.
m11o
force-pushed
the
feature/update-nodesource-docs
branch
from
d7396bf to
9a1d027
Compare
zzak
approved these changes
Nov 3, 2023
akhilgkrishnan
approved these changes
Nov 3, 2023
p8
pushed a commit
to p8/rails
that referenced
this pull request
Nov 4, 2023
p8
added a commit
that referenced
this pull request
Nov 4, 2023
…49916) Co-authored-by: Vipul A M <vipul@hey.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
ref: #49900
According to nodesource/distributions,
So, This Pull Request has been created because of updating to new installation method for nodejs by using nodesource/distributions.
Detail
This Pull Request removes nodesource script (
setup_XX.x) and updates nodejs installation method forUbuntuandFedora or CentOSin development_dependencies_install.md.Additional information
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]