Fix several of the rubygem issues in rails 2-3-stable. #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…VER change the semantics of the parent (returning nil if default).
name and requirement. Better, just activate the spec for the dependency (1.8 only)
This may cause problems. I dunno. The real solution is to get rid of all of this mess and use gem paths properly.
|
shit shit shit... I said I'd push my fixes to the specs/rakefiles... doing so now! |
+ Fixed deprecated usage in gemspecs. Bumped the version to 2.3.12 so I could test locally with actual installs. If this is bad form for this project, please beat me up and I'll split them out.
|
BTW, you may use gemsets for local tests instead of bumping versions. |
|
The part about rake/rdoctask => rdoc/task has already been committed b921679 |
|
flippingbits: I don't use rvm and was installing into a private gem repo (essentially a gemset) with 2.3.11 for performance testing (with 300ish other gems). dmathieu: thanks, but I did this more than 14 hours ago :) I guess it doesn't need to be backported then (since that was on master). Alternatively, I can roll that commit out and we can backport... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a lot of simple errors with railties' gem code causing exceptions to be raised when starting a rails 2.3 app with rubygems 1.8.x installed. This fixes those errors. This should also address nearly all deprecations.
I still need to work the use of SourceIndex out of it, but that can come later.