Cosmetic cleanup of generated Gemfile #9955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rubys
commented
Mar 27, 2013
rubys
commented
- Remove obsolete/misleading comment about assets only being used production
- Remove unnecessary group :assets
- Eliminate blank lines if options[:skip_javascript] is not specified
| GEMFILE | ||
| end | ||
|
|
||
| if options[:skip_javascript] |
There was a problem hiding this comment.
I think this should be unless
There was a problem hiding this comment.
Just to be clear, the lines it is replacing are:
#{coffee_gemfile_entry if options[:skip_javascript]}
#{javascript_runtime_gemfile_entry(2) if options[:skip_javascript]}
Are you suggesting that those lines are buggy?
- Remove obsolete/misleading comment about assets only being used production - Remove unnecessary group :assets - Eliminate blank lines if options[:skip_javascript] is not specified
based on a discussion with @rafaelfranca
rafaelfranca
added a commit
that referenced
this pull request
Mar 27, 2013
Cosmetic cleanup of generated Gemfile
jrafanie
added a commit
to jrafanie/manageiq
that referenced
this pull request
May 15, 2017
It was removed here: rails/rails#9955 The rails 5.1.0 template has just `Bundler.require(*Rails.groups)` here: https://github.com/rails/rails/blob/v5.1.0/railties/lib/rails/generators/rails/app/templates/config/application.rb#L21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.