Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign "Constants" section #356

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

jonathanhefner
Copy link
Member

This changes the appearance of the "Constants" section to match the "Methods" sections.

Before After
before after

This changes the appearance of the "Constants" section to match the
"Methods" sections.
@jonathanhefner jonathanhefner merged commit d26434f into rails:main Jan 4, 2024
9 checks passed
@p8
Copy link
Member

p8 commented Jan 5, 2024

This looks nice!
Code indentation seems to be ignored:
image
https://deploy-preview-356--sdoc.netlify.app/classes/activerecord

@jonathanhefner
Copy link
Member Author

Code indentation seems to be ignored:

Unfortunately, that is value that RDoc::Constant#value returns. I believe it is due to the way parse_constant_body is implemented (specifically, due to the get_tkread_clean(/^[ \t]+/, '') calls). I'm not sure whether the end result is intentional or accidental.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants