Changed the value used for $0 in subcommands #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$0 should be the first element of argv, which is generally the name of the program being run. Right now Spring is including the rest of argv as well. This is a problem for RSpec, which varies its behavior based on $0. Fixes rails#359
jonleighton
added a commit
that referenced
this pull request
Dec 9, 2014
Changed the value used for $0 in subcommands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$0 should be the first element of argv, which is generally the name of the program being run. Right now Spring is including the rest of argv as well. This is a problem for RSpec, which varies its behavior based on $0.
There's a lot more information on this issue here.
@jonleighton suggested fixing spring instead of spring-commands-rspec, and he also wrote the original code that this patch modifies, so this seems like a shoo-in.
Fixes #359