Let WebConsole.logger respect Rails.logger #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to set WebConsole.logger during Bundle.require time, which happened to be way earlier than when Rails.logger was initialized, so we always ended up with `STDERR` logger. In this change, we let `WebConsole.logger` to dynamically call `Rails.logger`, which will let us use it once initialized. If by the time we try to log something, `Rails.logger` isn't initialized or is explicitly set to nothing, we'll still fallback to the `STDERR` logging.
|
r? @matthewd |
This was referenced Apr 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to set WebConsole.logger during Bundle.require time, which
happened to be way earlier than when Rails.logger was initialized, so we
always ended up with
STDERRlogger. In this change, we letWebConsole.loggerto dynamically callRails.logger, which will letus use it once initialized. If by the time we try to log something,
Rails.loggerisn't initialized or is explicitly set to nothing, we'llstill fallback to the
STDERRlogging.