Support Stimulus Default Pack #1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webpacker:install:stimulus
added controllers directory and hello_controller.js
HELLO stimulus!
Wrapping it up with stimulus.rb
include stimulus in README.md
Remove hello_stimulus.js
Append setup code to application.js
👮♂️Satisfy robocop
From CI "Use the new Ruby 1.9 hash syntax.
inject_into_file "#{Webpacker.config.source_entry_path}/application.js", :after => "console.log('Hello World from Webpacker')" do"
use append_to_file instead of inject_into_file
add whitespace
rename setup.js to application.js
remove whitespace
added a \n
this.outputTarget.textContent = 'Hello Stimulus!'
✂️
✂️ to appease robocop
fix: cannot find module "controllers"
revert back to "controllers"
Added the expectant HTML in comments. 🤰
✂️, Edit comments, and changed to 'Hello, Stimulus!'
Use source_path instead of source_entry_path
missing "
Closed
|
Thank you! |
|
Thanks for your patience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is adding support of Stimulus via Webpacker.
app/javascript/packs/controllersdirectoryapp/javascript/packs/application.jsFor more information on Stimulus, please go to stimulusjs.org or read The Stimulus Handbook
To try it now:
Paste this into your
pages#indexAnd visit http://localhost:3000/pages