Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal Has Two Sets of Buttons #2181

Closed
benhutton opened this issue Feb 2, 2015 · 1 comment · Fixed by #2188
Closed

Modal Has Two Sets of Buttons #2181

benhutton opened this issue Feb 2, 2015 · 1 comment · Fixed by #2188

Comments

@benhutton
Copy link

image

I believe that this line is supposed to remove the duplicate set of buttons: https://github.com/sferik/rails_admin/blob/master/app/assets/javascripts/rails_admin/ra.remote-form.js#L73

But f6d660f changed .form-actions to .form-group, which probably should not be removed quite so aggressively.
@rikkipitt
Copy link
Contributor

Good shout. .form-actions isn't a class used in Bootstrap anymore, so perhaps we should leave it in on the _submit_buttons.html.erb partial. I've tested locally and it works fine. I'll submit a pull request later today, it's only a 1 line fix.

@rikkipitt rikkipitt mentioned this issue Feb 17, 2015
Merged
mshibuya added a commit that referenced this issue Feb 25, 2015
@mshibuya
Merge pull request #2188 from jemcode/master
6c7dfad 
Updated _submit_buttons.html.haml. Fixes #2181.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated _submit_buttons.html.haml. Fixes #2181.
2 participants
@benhutton @rikkipitt