Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#129: Support key decrypting on init for openssl3 #132

Merged
merged 1 commit into from
Aug 29, 2022
Merged

#129: Support key decrypting on init for openssl3 #132

merged 1 commit into from
Aug 29, 2022

Conversation

tobischo
Copy link
Collaborator

Openssl3 changes some underlying behaviours

By not re-using the cipher for decrypting the keys, we can ensure that the key loading code works with both openssl 1.1.1 and openssl 3

@tobischo tobischo requested a review from bumi July 31, 2022 11:25
@tobischo tobischo mentioned this pull request Jul 31, 2022
Closed
thibaudgg added a commit to csa-admin-org/csa-admin that referenced this pull request Aug 6, 2022
@thibaudgg
Epics, give a try on openssl3 with heroku-22 stack
4e97450 
- railslove/epics#129
- railslove/epics#132
@tobischo
Copy link
Collaborator Author

tobischo commented Aug 29, 2022 •
edited
Loading

@bumi @kangguru Could either of you spare some time for the review here? (And once this is done for getting the 2.0 released, see #131)

bumi
bumi approved these changes Aug 29, 2022
View reviewed changes
Copy link
Collaborator

@bumi bumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK - code looks good.

thanks for the comment about the memozation. and cipher was also a private method, so that's good.

@tobischo
Copy link
Collaborator Author

Thank you, I tested it against the subsembly test API and it was also tested against some production cases with production cases. Will merge it and then rebase the v2.0.0 branch

@tobischo tobischo merged commit fdd7d7c into master Aug 29, 2022
@tobischo tobischo deleted the bug/support-key-decrypting-on-init-for-openssl3 branch February 7, 2023 18:35
@tobischo tobischo restored the bug/support-key-decrypting-on-init-for-openssl3 branch February 7, 2023 18:35
@tobischo tobischo deleted the bug/support-key-decrypting-on-init-for-openssl3 branch April 15, 2023 13:29
@tobischo tobischo restored the bug/support-key-decrypting-on-init-for-openssl3 branch April 15, 2023 13:30
@tobischo tobischo deleted the bug/support-key-decrypting-on-init-for-openssl3 branch April 15, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bumi bumi bumi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobischo @bumi