Initialize RSA public key through ASN1 sequence #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobischo
force-pushed
the
feature/initialize_bank_public_key_without_set_key
branch
from
093e6b0
to
ccffdbc
Compare
|
I just double checked it against our own EBICS configurations and the credit suisse testing account - it still worked as intended. So if it works for you on OpenSSL that should solve the issue for now |
frantisekrokusek
approved these changes
Apr 14, 2023
There was a problem hiding this comment.
@tobischo for now I seem not to have any errors in my manual tests 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Openssl 3 does not support set_key anymore, however the method still exists.
This change happened to make the key objects immutable.
However it also breaks the way the public key of the EBICS provider is initialized for now
This addresses #138