bugfix: locale switch #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stringparser
commented
Sep 15, 2021
| persistLocale(locale) | ||
|
|
||
| setTimeout(() => router.reload(), 300) |
There was a problem hiding this comment.
It seems we do have to reload a page when changing the locale. Somehow client side there are some issues with state for useQuery. Or at least that is true for /checkin. The result of useArea is empty and this is why the bug here happens.
Couldn't find out why the query has no data but after reload it was all good.
bitboxer
approved these changes
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #326 (rework).
A better fix than what it was done in #327. Could test now in
localhostby adding a condition onpages/checkinfor development to not redirect. See below.To test locally you can use this URL:
http://localhost:3000/checkin?a=4e8f4906-ce9d-4590-9d4e-6df5a2939d39&k=VCW%2FKvtAiZ8mwTtMLHRJkSIgn%2FnLKvMZ9XwfXyzBvko%3D