-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It doesn't actually depend on rails, just railties #97
Conversation
This allows an application not to download the activerecord and arel gems for instance, if they don't use such ORM. As long as the application itself doesn't depend on the rails gem but railties instead.
Hello, @rosenfeld . I think, you should add new test env to https://github.com/railsware/js-routes/blob/master/Appraisals, generate new gemspec ( |
Ok, I'll try to give it a try later today. |
Indeed, I missed another required js-routes dependency, added by the rails gem: sprockets-rails :) |
js-routes definitely depends on actionpack. Please include it as well if it is not part of railties dependencies. |
Railties already depends on actionpack: https://github.com/rails/rails/blob/master/railties/railties.gemspec#L27 |
@rosenfeld Why we need |
The Rails application itself seems to need it probably due to some default configs, but this is not a js-routes dependency. All existing Rails applications will either have it or won't need tzinfo. I don't think we should worry about it. |
Otherwise we should change the test application defaults not to rely on tzinfo, but I think this may be harder then we may initially think it would... And more fragile too... |
@rosenfeld As I can see |
I added it because some test failed without it, but maybe you're right about rails40, didn't test it without that dependency. Will do and let you know. |
That's right, rails40 doesn't need it. I'll remove it and push the changes |
done |
Looks good. Need wait for @bogdan - what he will say. |
Also looks good for me. Merging in. |
It doesn't actually depend on rails, just railties
Thank you :) Any estimates for next release? ;) |
+1 for release, because master have fix for IE :) |
check 0.9.7 |
Thanks :-) |
This allows an application not to download the activerecord and arel gems for instance, if they don't use such ORM. As long as the application itself doesn't depend on the rails gem but railties instead.
I've actually tested this locally in my own application since I use Sequel as the ORM solution.
The only gem I depend on that still depends on rails is js-routes. Please consider applying this patch.