Feat/docker cert path #1165
Merged
Feat/docker cert path #1165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coffee-cup
approved these changes
Aug 26, 2024
|
Hi @coffee-cup, thanks i appreciate 👍 |
|
I have fix the linter i should be good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @coffee-cup,
I'm recreating this pull request following the closure of the previous one. As discussed earlier, I'm proposing to add a parameter to specify the Docker cert path.
I understand your concern about not wanting to integrate too much Docker configuration into Nixpacks. However, since there is already a variable to specify a Docker host (docker-host), it seems logical to add another variable specifically for establishing a secure connection with this host. This would make it easier for users who want to secure their connection without manually configuring every aspect.
Please let me know your thoughts on this. I'm also open to suggestions on how to test this new feature.
Thank you for your understanding and time!