Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no tab and links #5613

Merged
merged 7 commits into from
Apr 10, 2024
Merged

Fix no tab and links #5613

merged 7 commits into from
Apr 10, 2024

Conversation

brunobar79
Copy link
Member

@brunobar79 brunobar79 commented Apr 9, 2024

Fixes APP-####

What changed (plus any additional context for devs)

  • Fixes the issue where there is no tab when you see the dapp browser for the first time.
  • Fixes the links of the homepage cards.

Screen recordings / screenshots

Screen.Recording.2024-04-09.at.4.14.55.PM.mov

What to test

src/components/DappBrowser/DappBrowser.tsx Outdated Show resolved Hide resolved
Co-authored-by: Christian Baroni <christianbaroni@me.com>
@brunobar79 brunobar79 closed this Apr 10, 2024
@brunobar79 brunobar79 reopened this Apr 10, 2024
@brunobar79 brunobar79 merged commit 2d4ee4e into develop Apr 10, 2024
6 checks passed
@brunobar79 brunobar79 deleted the @bruno/fix-no-tab-and-links branch April 10, 2024 19:27
BrodyHughes added a commit that referenced this pull request Apr 17, 2024
…ecks-language

* 'develop' of github.com:rainbow-me/rainbow: (100 commits)
  [WIP]: Swaps v2 quote fetching (#5601)
  chore: app start up spring cleaning (#5622)
  fix remote config (#5627)
  would it kill you to log this only once (#5626)
  Recents (#5625)
  wc: improvements (#5616)
  Degen chain support (#5621)
  send: check contract address (#5586)
  tx requests: metadata (#5584)
  audit: phin (#5624)
  Fix: Wallets being marked as backed up by walletLoadState() (#5593)
  NFTs: filter instead of throw error when NFT has invalid network (#5537)
  Dapp Browser: Search (#5617)
  Browser: bug fixes, animation and UI improvements (#5618)
  cleanup file imports and duplicate types (#5619)
  requests: generalize analytics (#5589)
  browser: account icon clean up (#5612)
  Fix no tab and links (#5613)
  more e2e changes (#5558)
  . (#5615)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants