-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dapp Browser: Search #5617
Dapp Browser: Search #5617
Conversation
…@benisgold/db-search2
…@benisgold/db-search2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I was gonna suggest we debounce before calling search but you're fetching the entire list ahead and filtering local which seems to be fine for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great
…@benisgold/db-search2
…ecks-language * 'develop' of github.com:rainbow-me/rainbow: (100 commits) [WIP]: Swaps v2 quote fetching (#5601) chore: app start up spring cleaning (#5622) fix remote config (#5627) would it kill you to log this only once (#5626) Recents (#5625) wc: improvements (#5616) Degen chain support (#5621) send: check contract address (#5586) tx requests: metadata (#5584) audit: phin (#5624) Fix: Wallets being marked as backed up by walletLoadState() (#5593) NFTs: filter instead of throw error when NFT has invalid network (#5537) Dapp Browser: Search (#5617) Browser: bug fixes, animation and UI improvements (#5618) cleanup file imports and duplicate types (#5619) requests: generalize analytics (#5589) browser: account icon clean up (#5612) Fix no tab and links (#5613) more e2e changes (#5558) . (#5615) ...
…eplink-add * 'develop' of github.com:rainbow-me/rainbow: (23 commits) Add SmoothPager (#5641) [APP-1370]: bump sentry sdk to latest (#5640) Browser refactor (#5638) bump version to v1.9.22 (#5634) Price Impact Warning (#5635) Disable welcome screen animations when IS_TESTING (#5637) init (#5495) [WIP]: Swaps v2 quote fetching (#5601) chore: app start up spring cleaning (#5622) fix remote config (#5627) would it kill you to log this only once (#5626) Recents (#5625) wc: improvements (#5616) Degen chain support (#5621) send: check contract address (#5586) tx requests: metadata (#5584) audit: phin (#5624) Fix: Wallets being marked as backed up by walletLoadState() (#5593) NFTs: filter instead of throw error when NFT has invalid network (#5537) Dapp Browser: Search (#5617) ...
Fixes APP-1266
What changed (plus any additional context for devs)
This PR adds search functionality. It will show the top 3 results from our dapp metadata repo, which includes 1500+ verified/unverified dapps.
Search algo:
To do:
Screen recordings / screenshots
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-04-10.at.12.50.42.mp4
What to test