New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tx requests: metadata #5584
Merged
Merged
tx requests: metadata #5584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skylarbarrera
added
the
release
for release blockers and release candidate branches
label
Apr 9, 2024
benisgold
approved these changes
Apr 11, 2024
walmat
approved these changes
Apr 12, 2024
walmat
reviewed
Apr 12, 2024
const metadata = await fetchDappMetadata({ url: peerMeta.url, status: true }); | ||
|
||
const dappName = metadata?.appName || peerMeta.name || lang.t(lang.l.walletconnect.unknown_dapp); | ||
const dappImage = metadata?.appLogo || peerMeta?.icons?.[0]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should have a fallback here
BrodyHughes
added a commit
that referenced
this pull request
Apr 17, 2024
…ecks-language * 'develop' of github.com:rainbow-me/rainbow: (100 commits) [WIP]: Swaps v2 quote fetching (#5601) chore: app start up spring cleaning (#5622) fix remote config (#5627) would it kill you to log this only once (#5626) Recents (#5625) wc: improvements (#5616) Degen chain support (#5621) send: check contract address (#5586) tx requests: metadata (#5584) audit: phin (#5624) Fix: Wallets being marked as backed up by walletLoadState() (#5593) NFTs: filter instead of throw error when NFT has invalid network (#5537) Dapp Browser: Search (#5617) Browser: bug fixes, animation and UI improvements (#5618) cleanup file imports and duplicate types (#5619) requests: generalize analytics (#5589) browser: account icon clean up (#5612) Fix no tab and links (#5613) more e2e changes (#5558) . (#5615) ...
BrodyHughes
added a commit
that referenced
this pull request
Apr 18, 2024
…eplink-add * 'develop' of github.com:rainbow-me/rainbow: (23 commits) Add SmoothPager (#5641) [APP-1370]: bump sentry sdk to latest (#5640) Browser refactor (#5638) bump version to v1.9.22 (#5634) Price Impact Warning (#5635) Disable welcome screen animations when IS_TESTING (#5637) init (#5495) [WIP]: Swaps v2 quote fetching (#5601) chore: app start up spring cleaning (#5622) fix remote config (#5627) would it kill you to log this only once (#5626) Recents (#5625) wc: improvements (#5616) Degen chain support (#5621) send: check contract address (#5586) tx requests: metadata (#5584) audit: phin (#5624) Fix: Wallets being marked as backed up by walletLoadState() (#5593) NFTs: filter instead of throw error when NFT has invalid network (#5537) Dapp Browser: Search (#5617) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-1276
What changed (plus any additional context for devs)
fix remaining dapp metadata issues
Screen recordings / screenshots
What to test