[WIP]: Swaps v2 quote fetching #5601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@rainbow-me/swaps@0.15.0 |
walmat
requested review from
benisgold,
skylarbarrera and
jinchung
as code owners
skylarbarrera
approved these changes
Apr 15, 2024
| // assetToSell => native currency | ||
| case 2: { | ||
| fromAssetText.value = `1 ${assetToSellSymbol.value}`; | ||
| toAssetText.value = `$${assetToSellPrice.value.toLocaleString('en-US', { |
There was a problem hiding this comment.
we shouldnt be using toLocaleString since it doenst play with with the rest of the supported currencies, we have a JS util might just need to write it as a worklet
There was a problem hiding this comment.
| 'worklet'; | ||
|
|
||
| const chainName = chainNameFromChainIdWorklet(chainId) as | ||
| | ChainName.mainnet |
There was a problem hiding this comment.
prob worth pulling this out into a supportedChains type or similar
There was a problem hiding this comment.
added a new ticket: https://linear.app/rainbow/issue/APP-1348/cleanup-supportedchains-type
| percentageToSwap.value, | ||
| sliderXPosition.value | ||
| ); | ||
| }); | ||
|
|
||
| const formattedInputNativeValue = useDerivedValue(() => { | ||
| if (inputMethod.value === 'slider' && percentageToSwap.value === 0 && !inputValues.value.inputNativeValue) return '$0.00'; | ||
| if ((inputMethod.value === 'slider' && percentageToSwap.value === 0) || !inputValues.value.inputNativeValue) { | ||
| return '$0.00'; |
There was a problem hiding this comment.
native currency shiz
There was a problem hiding this comment.
| @@ -161,7 +274,9 @@ export function useSwapInputsController({ | |||
| }); | |||
|
|
|||
| const formattedOutputNativeValue = useDerivedValue(() => { | |||
| if (inputMethod.value === 'slider' && percentageToSwap.value === 0 && !inputValues.value.outputNativeValue) return '$0.00'; | |||
| if ((inputMethod.value === 'slider' && percentageToSwap.value === 0) || !inputValues.value.outputNativeValue) { | |||
| return '$0.00'; | |||
There was a problem hiding this comment.
native currency shiz
There was a problem hiding this comment.
| const fetchPriceForAsset = async (asset: ParsedSearchAsset | null, assetType: 'assetToSell' | 'assetToBuy') => { | ||
| if (!asset) return; | ||
|
|
||
| const assetWithPriceData = await fetchExternalToken({ |
There was a problem hiding this comment.
this looks like the vanilla fetch which wont take advantage of caching/local data
There was a problem hiding this comment.
BrodyHughes
added a commit
that referenced
this pull request
Apr 17, 2024
…ecks-language * 'develop' of github.com:rainbow-me/rainbow: (100 commits) [WIP]: Swaps v2 quote fetching (#5601) chore: app start up spring cleaning (#5622) fix remote config (#5627) would it kill you to log this only once (#5626) Recents (#5625) wc: improvements (#5616) Degen chain support (#5621) send: check contract address (#5586) tx requests: metadata (#5584) audit: phin (#5624) Fix: Wallets being marked as backed up by walletLoadState() (#5593) NFTs: filter instead of throw error when NFT has invalid network (#5537) Dapp Browser: Search (#5617) Browser: bug fixes, animation and UI improvements (#5618) cleanup file imports and duplicate types (#5619) requests: generalize analytics (#5589) browser: account icon clean up (#5612) Fix no tab and links (#5613) more e2e changes (#5558) . (#5615) ...
BrodyHughes
added a commit
that referenced
this pull request
Apr 18, 2024
…eplink-add * 'develop' of github.com:rainbow-me/rainbow: (23 commits) Add SmoothPager (#5641) [APP-1370]: bump sentry sdk to latest (#5640) Browser refactor (#5638) bump version to v1.9.22 (#5634) Price Impact Warning (#5635) Disable welcome screen animations when IS_TESTING (#5637) init (#5495) [WIP]: Swaps v2 quote fetching (#5601) chore: app start up spring cleaning (#5622) fix remote config (#5627) would it kill you to log this only once (#5626) Recents (#5625) wc: improvements (#5616) Degen chain support (#5621) send: check contract address (#5586) tx requests: metadata (#5584) audit: phin (#5624) Fix: Wallets being marked as backed up by walletLoadState() (#5593) NFTs: filter instead of throw error when NFT has invalid network (#5537) Dapp Browser: Search (#5617) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Known issues: