Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swaps: coin row info button #5791

Merged
merged 4 commits into from
May 31, 2024
Merged

Swaps: coin row info button #5791

merged 4 commits into from
May 31, 2024

Conversation

benisgold
Copy link
Member

Fixes APP-1527

What changed (plus any additional context for devs)

Screen recordings / screenshots

IMG_8527.MOV
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-05-30.at.17.31.58.mp4

What to test

@benisgold benisgold requested a review from walmat May 31, 2024 00:34
@linear Linear
Copy link

linear bot commented May 31, 2024

APP-1527 Hitting "i" info button on a token row in swap search does not do anything (not hooked up)

@benisgold benisgold requested a review from walmat May 31, 2024 16:22
@benisgold benisgold merged commit 0b2610e into develop May 31, 2024
6 checks passed
@benisgold benisgold deleted the @benisgold/infobutton branch May 31, 2024 17:17
BrodyHughes added a commit that referenced this pull request Jun 1, 2024
@BrodyHughes
Merge branch 'develop' of github.com:rainbow-me/rainbow into develop
b22dade 
* 'develop' of github.com:rainbow-me/rainbow:
  Backups v2 IDFA check (#5653)
  Swaps: coin row info button (#5791)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walmat walmat walmat approved these changes

Assignees
No one assigned
Labels
swaps v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benisgold @walmat