Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add max swappable amount on balance badge tap #5947

Merged
merged 10 commits into from
Jul 25, 2024
Merged

Add max swappable amount on balance badge tap #5947

merged 10 commits into from
Jul 25, 2024

Conversation

walmat
Copy link
Contributor

@walmat walmat commented Jul 23, 2024 •
edited
Loading

Fixes APP-1557

What changed (plus any additional context for devs)

Adds balance badge press setting max swappable amount for asset if user has balance.

Note I also added the functionality to output balance badge.

Screen recordings / screenshots

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-07-23.at.12.04.23.mp4

What to test

@linear Linear
Copy link

linear bot commented Jul 23, 2024

APP-1557 On Balance Press should set input / output amount to that amount

greg-schrammel
greg-schrammel approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@greg-schrammel greg-schrammel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

jinchung
jinchung requested changes Jul 24, 2024
View reviewed changes
Copy link
Member

@jinchung jinchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I think having this functionality on the output badge will not be that useful @christianbaroni if you have thoughts here
  2. This adds duplicate code, can we have the onSetMaxBalance worklet pulled out separately and shared across the SwapSlider and SwapInputAsset? Assuming we don't do the output asset, this simplifies it even more. This is for maintenance considerations going forward, if we need to update this logic, it's easier to just update in one place than in two or three.

@walmat walmat requested a review from jinchung July 24, 2024 16:07
@walmat walmat requested a review from jinchung July 25, 2024 21:12
jinchung
jinchung approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@jinchung jinchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@jinchung jinchung merged commit 48bec8c into develop Jul 25, 2024
6 checks passed
@jinchung jinchung deleted the @matthew/add-balance-tap branch July 25, 2024 22:36
BrodyHughes added a commit that referenced this pull request Jul 26, 2024
@BrodyHughes
Merge branch 'develop' of github.com:rainbow-me/rainbow into brody/sw…
15e9b05 
…ap-v2-e2e-test-2

* 'develop' of github.com:rainbow-me/rainbow:
  [e2e] Manual backup e2e test (#5913)
  . (#5958)
  Add max swappable amount on balance badge tap (#5947)
  changelog (#5957)
  chore: set referrer for claims (#5954)
  remove FULL_SCREEN_INTENT permission (#5955)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinchung jinchung jinchung approved these changes

@greg-schrammel greg-schrammel greg-schrammel approved these changes

Assignees
No one assigned
Labels
swaps v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@walmat @jinchung @greg-schrammel