Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase z-index of modal #201

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

markdalgleish
Copy link
Contributor

No description provided.

@markdalgleish markdalgleish requested a review from a team as a code owner March 28, 2022 22:40
@linear
Copy link

linear bot commented Mar 28, 2022

RNBW-2937 Ensure modal isn't rendered below other elements

Right now the modal is rendered to a portal at the end of the document which gives it a higher default zIndex, but it means that any element with an explicit positive zIndex will render on top of it. We should provide a higher default value while ensuring that it renders beneath the WalletConnect and Coinbase modals.

We may also want to allow consumers to customize the zIndex value.

@vercel
Copy link

vercel bot commented Mar 28, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

rainbowkit-example – ./

🔍 Inspect: https://vercel.com/rainbowdotme/rainbowkit-example/FBq68T4rnifhk2ifb8mGomKKYoSp
✅ Preview: https://rainbowkit-example-git-markdalgleish-rnbw-2-c17294-rainbowdotme.vercel.app

rainbowkit-site – ./

🔍 Inspect: https://vercel.com/rainbowdotme/rainbowkit-site/7PUQEMfo7ihw6AGgqvnte1G4TgxU
✅ Preview: https://rainbowkit-site-git-markdalgleish-rnbw-2937-b16af1-rainbowdotme.vercel.app

@markdalgleish markdalgleish merged commit 8d0025a into main Mar 29, 2022
@markdalgleish markdalgleish deleted the @markdalgleish/RNBW-2937-increase-modal-zindex branch March 29, 2022 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants