This repository has been archived by the owner on Oct 13, 2021. It is now read-only.
fix missing parameter. Test cover of Pgbackups class #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def existing_backups? | ||
| @heroku.client.addon.list(heroku_app_name).select do |addon| | ||
| def existing_backups?(heroku_app_name) | ||
| @heroku.client.addon.list(heroku_app_name).any? do |addon| |
There was a problem hiding this comment.
Does that any? replace the select then the any? on selected stuff?
There was a problem hiding this comment.
Yes, it does.
Here you can see another place where any? is being used in same way (and also checking if any addon of the list has a specific name).
2.1.2 :001 > [1,2,3,4,5].select { |num| num.even? }
=> [2, 4]
2.1.2 :002 > [1,2,3,4,5].select { |num| num.even? }.any?
=> true
2.1.2 :003 > [1,2,3,4,5].any? { |num| num.even? }
=> true
|
Other than that question, this looks good to me. |
jipiboily
added a commit
that referenced
this pull request
Mar 5, 2015
fix missing parameter. Test cover of Pgbackups class
|
New version released on Rubygems. Thanks! :) |
|
🆒 ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I am again.
After applying changes done at #54, we tried again and found a new problem.
Seems that during a method extraction refactor (f27c084) the typical "oh, I forget to pass the parameter to the new extracted method" (happens too many times to me U_U') was introduced.
So the new method is calling
heroku_app_name, variable that is not defined in his scope.I tried to avoid future errors through a basic test covering of the class. I'm not proud of tests that I created here, since I had to stub A LOT just to be able to test what calls we want to be done.
Also it was very difficult for me trying to isolate expectations to one per test, because if I isolate expectations I would have to create new stubs for the different internal calls at each test. So, tired of trying too complicated things, I decided to move to a "well, it works" approach. Better than nothing.