Fixed temperature bulbs to only show temperature capability in Home app. #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome ! Can’t wait to test it out |
rainlake
requested changes
Apr 9, 2018
|
Created new PR with package name and repos reverted #15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before they were showing up with full-colour palate available.
Colour temperature is actually governed by "mired" in Homekit, not hue or Kelvin, as such I have removed saturation and hue capabilities and added the ColorTemperature characteristic to the temperature bulbs as well as the necessary mired conversions to and from Kelvin:
http://cbkmrks.blogspot.co.uk/2013/03/color-temperature-mired-scale-dailey.html
I have also lowered the log level of discovery actions as the log gets extremely verbose and chatty otherwise.
Also resolves part of #11 by removing hard-coded return of a hue "1" for temperature bulbs and instead returning mired value.