added macros for database tests

[saikishore222]

added macros for database tests to remove the repetitive test and make it simple using declarative macros. Macros are inserted

in memory.rs,keyvalue.rs.

Co-authored-by : SanthoshAnguluri santhoshanguluri15@gmail.com

[rajarshimaitra]

Looks good to me.. Below are some comments.. Great going..

Few more tasks in gen

• Add Santosh as a co-author too.. This PR itself will be used as a documentation for your works.. So its important both participants are reflected in the contents..

• Add signature to your commits.. This is standard requirement for contributing to most FOSS projects out there.. Heres the steps.. https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

[rajarshimaitra]

Look good..

Few more nits..

[rajarshimaitra]

Suggested change

	macro_rules! run_tests_with_constructor {
	(getter $fn_name:ident(), tests ( $($x:tt) , + $(,)? )) => {
	macro_rules! run_tests_with_initialiser {
	(init $fn_name:ident(), tests ( $($x:tt) , + $(,)? )) => {

[rajarshimaitra]

One more redundant extra line..

[rajarshimaitra]

redundant line..

[rajarshimaitra]

Still not sure how but I am seeing two more redundant lines..

Use cargo fmt and cargo clippy before you push changes..

[rajarshimaitra]

Redundant line..

[rajarshimaitra]

Redundant line..

[rajarshimaitra]

The tests are failing because you need change populate_db! here too..

bdk/src/testutils/mod.rs

Line 246 in 00fdf8d

let txid = populate_test_db!(

The macro doesn't exist anymore..

Also before committing changes locally run all the tests to make sure nothing is broken..

To get a list of all the CI tests checkout this file..

bdk/.github/workflows/cont_integration.yml

Lines 15 to 53 in 474620e

	features:
	- default
	- minimal
	- all-keys
	- minimal,esplora
	- key-value-db
	- electrum
	- compact_filters
	- esplora,key-value-db,electrum
	- compiler
	- rpc
	- verify
	steps:
	- name: checkout
	uses: actions/checkout@v2
	- name: Generate cache key
	run: echo "${{ matrix.rust }} ${{ matrix.features }}" | tee .cache_key
	- name: cache
	uses: actions/cache@v2
	with:
	path: |
	~/.cargo/registry
	~/.cargo/git
	target
	key: ${{ runner.os }}-cargo-${{ hashFiles('.cache_key') }}-${{ hashFiles('**/Cargo.toml','**/Cargo.lock') }}
	- name: Set default toolchain
	run: rustup default ${{ matrix.rust }}
	- name: Set profile
	run: rustup set profile minimal
	- name: Add clippy
	run: rustup component add clippy
	- name: Update toolchain
	run: rustup update
	- name: Build
	run: cargo build --features ${{ matrix.features }} --no-default-features
	- name: Clippy
	run: cargo clippy --all-targets --features ${{ matrix.features }} --no-default-features -- -D warnings
	- name: Test
	run: cargo test --features ${{ matrix.features }} --no-default-features

It might make sense to make a small shell script with all the cargo tests and run that before pushing changes..

[rajarshimaitra]

I pushed all these changes after the comment fix and few more refactors into the PR branch https://github.com/rajarshimaitra/bdk/commits/test-helper-refactor

I am closing this PR, in favor of that.. Its required lot of conflict resolution.. So the merge didn't haven't as clean as I expected..

For further work open PR new on the original branch..