-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SPM compilation #82
Conversation
# Conflicts: # Proton/Sources/ProtonCore/ListParser.swift
@vmanot, it seems that the files have not been correctly referenced in the Project. The build is failing for the same reason: https://github.com/rajdeep/proton/pull/82/checks |
I see the same as @rajdeep. I tried to manually fix the reference issues but it wasn't enough it seems. Importing this branch as a Swift Package works but building it locally doesn't. The reason is that the local project needs to have the ProtonCore framework as well. Otherwise the |
@YoX89 the changes were beyond just fixing the references as over time there was cyclic dependency created between ObjC and Swift code. Since ObjC code now needed it's own module, I had to change bits to break the dependency of ObjC code on Swift. You should be able to try the latest branch for |
Fixes #82, building upon #26.
You would not believe the number of hacks I went through to get this to work.
Implementation
ProtonCore
- to be consumed byProton
(still a single package though)ProtonCore
Proton
's ObjC declarations.Proton
to cast wherever appropriate.