Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional dependency OdesPy #3

Closed
khinsen opened this issue Jun 22, 2020 · 1 comment
Closed

Optional dependency OdesPy #3

khinsen opened this issue Jun 22, 2020 · 1 comment

Comments

@khinsen
Copy link
Contributor

khinsen commented Jun 22, 2020

The instructions for installation from source mention OdesPy as an optional dependency, but don't say what difference OdesPy makes. Does it add functionality? Improve performance? As a JOSS reviewer, should I test PyStokes with or without OdesPy?
rajeshrinet added a commit that referenced this issue Jun 22, 2020
@rajeshrinet
update description of optional odespy #3
717871b
@rajeshrinet
Copy link
Owner

@khinsen, OdesPy is not essentially for reviewing the code. OdesPy has been suggested as an optional dependency as it provides various fixed-step and adaptive-step integrators with a neat interface. The default integrator is scipy.integrate.odeint. Thus, once scipy is installed, all the examples of PyStokes should run.

I have now added a short note on this in the README when I list OdesPy as an optional dependency. Thanks.

@khinsen khinsen closed this as completed Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@khinsen @rajeshrinet