Adding option to turn on go templating of fleet values. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add option to turn on/off helm values templating Signed-off-by: Greg Sidelinger <gate@ilive4code.net>
Remove some extra code that is not needed for dealing with cluster labels
rajiteh
reviewed
Feb 19, 2022
rajiteh
force-pushed
the
template_values
branch
from
ddb4e5e
to
b191284
Compare
…to template_values Signed-off-by: Greg Sidelinger <gate@ilive4code.net>
Go templating is not on by default for helm values Signed-off-by: Greg Sidelinger <gate@ilive4code.net>
|
Was over thinking trying to change the boolean value to a default of true. I enabled up just changing the name of the option in the CRD to disablePreProcess. Will nag the rancher fleet team next week via work if you like the direction your PR is going because I really want these features for use at work. |
rajiteh
added a commit
that referenced
this pull request
Mar 11, 2022
feat: disablePreProcessing flagl to disable Go templating for helm values Signed-off-by: Greg Sidelinger <gate@ilive4code.net> Co-authored-by: Raj Perera <rajiteh@gmail.com>
rajiteh
added a commit
that referenced
this pull request
Apr 11, 2022
feat: disablePreProcessing flagl to disable Go templating for helm values Signed-off-by: Greg Sidelinger <gate@ilive4code.net> Co-authored-by: Raj Perera <rajiteh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.