Tsneez visualization #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajpurkar
requested changes
Jan 9, 2019
|
|
||
| // Set up visualization | ||
| var svg | ||
| var fadeOld = 0 |
There was a problem hiding this comment.
We need this as these are global variables.
| 'rotate(' + d.rotate + ')' | ||
| }) | ||
|
|
||
| s.selectAll('rect').style('fill-opacity', function (d) { |
There was a problem hiding this comment.
everything below thing line can be removed. deals with addition of new points
There was a problem hiding this comment.
ok and hence var fadeOld varaible also removed
|
|
||
|
|
||
| function dimensionReduce(vecs) { | ||
| var NUMBER_OF_EMBEDDINGS = 1000 |
There was a problem hiding this comment.
would pull this out to be defined at top of page
| font-size: 1em; | ||
| fill: #444; | ||
| } | ||
| .infoCard { |
There was a problem hiding this comment.
Info card and info body are not being used. remove!
| <body> | ||
| <div class="container"> | ||
| <div class="row"> | ||
| <div class="infoCard"> |
There was a problem hiding this comment.
Ok.
Added style for "container" class.
|
All changes are done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds tsneez visualization as example 3 in the README.md