Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the project still maintained? #13

Closed
antoninbas opened this issue Jan 28, 2021 · 4 comments · Fixed by #14
Closed

Is the project still maintained? #13

antoninbas opened this issue Jan 28, 2021 · 4 comments · Fixed by #14

Comments

@antoninbas
Copy link
Contributor

Hi - I wanted to check if the project is still maintained. If yes, would you be open to a PR with the following changes?

  • switch from vendoring dependencies to using Go modules
  • replace the current go-powershell dependency with https://github.com/antoninbas/go-powershell. This fork converts the project to Go modules and removes the dependency on juju packages (which are distributed under an LGPL v3 license, making usage in commercial products difficult)

Additionally, would you be willing to make a Github release/ create a tag after making the changes above?

Thanks

@rakelkar
Copy link
Owner

rakelkar commented Jan 28, 2021 via email

antoninbas added a commit to antoninbas/gonetsh that referenced this issue Jan 29, 2021
* Switch to Go modules and remove vendoring
* Use different fork of go-powershell: replace the current go-powershell
  dependency with https://github.com/antoninbas/go-powershell. This fork
  converts the project to Go modules and removes the dependency on juju
  packages (which are distributed under an LGPL v3 license, making usage
  in commercial products difficult)

Fixes rakelkar#13
antoninbas added a commit to antoninbas/gonetsh that referenced this issue Jan 29, 2021
* Switch to Go modules and remove vendoring
* Use different fork of go-powershell: replace the current go-powershell
  dependency with https://github.com/antoninbas/go-powershell. This fork
  converts the project to Go modules and removes the dependency on juju
  packages (which are distributed under an LGPL v3 license, making usage
  in commercial products difficult)
* Enable CI: run unit tests using Github workflows

Fixes rakelkar#13
antoninbas added a commit to antoninbas/gonetsh that referenced this issue Feb 5, 2021
* Switch to Go modules and remove vendoring
* Use different fork of go-powershell: replace the current go-powershell
  dependency with https://github.com/antoninbas/go-powershell. This fork
  converts the project to Go modules and removes the dependency on juju
  packages (which are distributed under an LGPL v3 license, making usage
  in commercial products difficult)
* Enable CI: run unit tests using Github workflows

Fixes rakelkar#13
rakelkar pushed a commit that referenced this issue Feb 26, 2021
* Switch to Go modules

* Switch to Go modules and remove vendoring
* Use different fork of go-powershell: replace the current go-powershell
  dependency with https://github.com/antoninbas/go-powershell. This fork
  converts the project to Go modules and removes the dependency on juju
  packages (which are distributed under an LGPL v3 license, making usage
  in commercial products difficult)
* Enable CI: run unit tests using Github workflows

Fixes #13

* Fix unit tests given k8s.io/util version update
@antoninbas
Copy link
Contributor Author

@rakelkar Thanks for merging #14. Do you think you could create a Github release tag?

@rakelkar
Copy link
Owner

rakelkar commented Mar 2, 2021

@antoninbas
Copy link
Contributor Author

Works for me, but why not start at v0.1.0 or something similar?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants