Max SCGI content size too small

[lps-rocks]

rtorrent/src/rpc/scgi_task.h

Line 54 in f0207ce

static const int max_content_size = (2 << 20);

This limits a max raw.load to 2MB - Should be increased or be made into a user setting based setting to match the xmlrpc size since XMLRPC rides on top of this SCGI protocol handler.

[kannibalox]

Looks like it's actually 2MB, but excellent find. I'd be in favor of setting the hard coded limit to something large like 32MB and letting network.xmlrpc.size_limit remain the sole user controlled setting.

[lps-rocks]

Looks like it's actually 2MB, but excellent find. I'd be in favor of setting the hard coded limit to something large like 32MB and letting network.xmlrpc.size_limit remain the sole user controlled setting.

Oops. Yup - i was off by one bit. I believe network.xmlrpc.size_limit has a maximum value of 16MB. I think synchronizing this limit with that one would be beneficial.

[xiayyu]

I tested using a lager max_content_size 1 << 24 (16M), which would allow us to add a lager torrent (>2M) via xmlrpc. Only change network.xmlrpc.size_limit alone won't help.

[lps-rocks]

I tested using a lager max_content_size 1 << 24 (16M), which would allow us to add a lager torrent (>2M) via xmlrpc. Only change network.xmlrpc.size_limit alone won't help.

That's the exact setting I used too since the max setting for network.xmlrpc.size_limit is 16M

[lps-rocks]

@rakshasa - Can this be merged in as soon as possible since it severely breaks SCGI?

[rakshasa]

@rakshasa - Can this be merged in as soon as possible since it severely breaks SCGI?

Make a pull request and I'll merge it.

[grigorescu]

Fixed in 14d7121