Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tracker before delete the torrent #899

Open
Feriman22 opened this issue Jul 28, 2019 · 6 comments
Open

Update tracker before delete the torrent #899

Feriman22 opened this issue Jul 28, 2019 · 6 comments

Comments

@Feriman22
Copy link

Hi,

I come from this thread. The author of ruTorrent sent me here.

I would like to set this below:
One torrent reached the defined ratio target and the action is "Remove data (All)". The tracker is not received yet the latest uploaded data size (how much data I uploaded since last refresh), so I have to update tracker before the plugin delete the torrent.

I'm using the ratio plugin of ruTorrent.

Is it possible?

Thank you!

@pyroscope
Copy link
Contributor

The author of ruTorrent sent me here.

Which is a cheap way avoiding an answer.

ruTorrent use rtorrent implementation of ratio system.

The actions called by the ratio rules are not written by rtorrent however, but by that plugin.

@Novik
Copy link

Novik commented Jul 28, 2019

The actions called by the ratio rules

Plugin call combination d.stop/d.close/d.erase. AFAIK this must be enough for updation of corresponding trackers.
In any case, AFAIR, rtorrent xmlrpc API doesn't provide commands for manual update of trackers.
I.e. this is a problem of client.

@chros73
Copy link
Contributor

chros73 commented Jul 29, 2019

rtorrent xmlrpc API doesn't provide commands for manual update of trackers.

Not just that but this kind of behaviour should be included in the client itself.
There's a similar issue when updating tracker is also needed when leeching a download has been finished.
rakshasa/libtorrent#191

I wouldn't await for a quick fix though, there are pending PRs that will modify the current behaviour of finishing downloading.

@rakshasa
Copy link
Owner

rakshasa commented Aug 1, 2019

Yes, this is an issue with the client not guaranteeing the event is sent to the tracker afaics.

Not a priority as I'm redoing other parts, however PRs are welcome.

@Feriman22
Copy link
Author

Thank you all! I'm waiting for the fix.

@chros73
Copy link
Contributor

chros73 commented Aug 2, 2019

however PRs are welcome

If the rest of my patches will be merged then I'll probably take a quick look into this ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants