Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "DNS-lookup" to "DNS lookup" in the report? #123

Open
ngrilly opened this issue Sep 5, 2018 · 1 comment
Open

Rename "DNS-lookup" to "DNS lookup" in the report? #123

ngrilly opened this issue Sep 5, 2018 · 1 comment

Comments

@ngrilly
Copy link

ngrilly commented Sep 5, 2018

I have doubts about the meaning of "DNS+dialup" and "DNS-lookup" in the reports produced by hey:

Details (average, fastest, slowest):
  DNS+dialup:	0.2696 secs, 0.0004 secs, 7.2027 secs
  DNS-lookup:	0.0000 secs, 0.0000 secs, 0.0000 secs
  req write:	0.0001 secs, 0.0000 secs, 0.0113 secs
  resp wait:	0.0004 secs, 0.0001 secs, 0.0078 secs
  resp read:	0.0001 secs, 0.0000 secs, 0.0092 secs

After a quick glance at the code here and here, it looks like "DNS+dialup" is the sum of the DNS lookup duration and the connection dial up duration, and "DNS-lookup" is the DNS lookup duration alone.

The spelling "DNS-lookup" suggests it is the duration of the DNS lookup minus some other "lookup".

Should we rename it to "DNS lookup"?
@rakyll
Copy link
Owner

rakyll commented Sep 5, 2018

Renaming it to "DNS lookup" sounds good.

ngrilly added a commit to ngrilly/hey that referenced this issue Sep 6, 2018
@ngrilly
Rename "DNS-lookup" to "DNS lookup" (fixes rakyll#123)
a126d44 
"DNS-lookup" could be interpreted as "DNS lookup duration minus some other lookup duration". This change removes the ambiguity.
@gdmello gdmello mentioned this issue Nov 15, 2019
Open
chunter0 pushed a commit to chunter0/hey that referenced this issue Apr 8, 2024
@llimllib
feat: add method property to responses (rakyll#123)
1223a73 
```console
# before: httpbingo lacks the "method" field but httpbin.org has it
$ curl -s https://httpbingo.org/anything | jq .method                                                                                                        9:31PM
null
$ curl -s https://httpbin.org/anything | jq .method
"GET"

# after: httpbingo has the method field!
$ curl -s http://0.0.0.0:8080/anything | jq .method
"GET"
```

This was mentioned in rakyll#6, but then not listed in rakyll#91

- I took the highly technical testing approach of adding a test for
`Method` anywhere in `handlers_test.go` that mentioned `Args`; do you
desire more tests? fewer tests?
- Anywhere else I should add this field that I didn't already?

For what it's worth, I discovered this when working on upgrading the
testing for our [httpsnippet
library](https://github.com/readmeio/httpsnippet); I wanted to use
`go-httpbin` but our tests expect the method field to be present in the
responses
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rakyll @ngrilly