Adding arrow on left of headers in help page #1075 #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1076 +/- ##
========================================
Coverage 97.94% 97.95%
========================================
Files 42 42
Lines 1560 1566 +6
Branches 418 419 +1
========================================
+ Hits 1528 1534 +6
Misses 31 31
Partials 1 1
Continue to review full report at Codecov.
|
|
@sam-glendenning Could you take a look at the new code I wrote? |
sam-glendenning
commented
Jun 7, 2022
|
Actually never mind, I have admin privileges, I'm happy with it, you're happy with it, we don't need this back and forth for a tiny PR |
louise-davies
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As the help page is by far the longest page, I've added an arrow next to each of the main headings in the help page which, when clicked, takes the user to the top of the page again so they don't have to scroll all the way back up. Due to the help page being constructed from pure HTML, I had to use a Unicode-style icon for the links. This also required some additional logic in the table of contents construction so the icon wouldn't appear in the header names.
I couldn't decide which side to have the arrow on so kept it on the left for now but this can be easily changed. Here's what they look like for reference:
Left:
Right:
Testing instructions
Go to /help and try it out!
Agile board tracking
Closes #1075