Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't load as binary #1

Merged
merged 1 commit into from
Apr 12, 2016
Merged

Don't load as binary #1

merged 1 commit into from
Apr 12, 2016

Conversation

MinchinWeb
Copy link
Contributor

If the file is loaded in binary mode, then comparisons need to be made in binary mode (which isn't being done).

I'm working with Python 3.5, so this may be a change between Python 2 and 3.

If the file is loaded in binary mode, then comparisons need to be made
in binary mode (which isn't being done).
@ralienpp
Copy link
Owner

ralienpp commented Apr 1, 2016

I tried the library with Python 3.5.1 (on Archlinux) and Python 3.4.3 (on Linux Mint), it works as expected without your change too.

Perhaps the problem is elsewhere?

  1. what OS are you running it on?
  2. what input data can I use to replicate the problem?

@MinchinWeb
Copy link
Contributor Author

I'm using Python 3.5.1 on Windows 10.

Here, I create a virtual environment, installed reyaml from pypi, created a simple text file from the commandline, loaded Python, and tried to load the file with reyaml. The existing library throws a TypeError (the last line).

image

@ralienpp ralienpp merged commit 646b535 into ralienpp:master Apr 12, 2016
@MinchinWeb MinchinWeb deleted the load-not-binary branch April 12, 2016 20:21
@ralienpp
Copy link
Owner

I forgot to publish it on PyPi, but it is there now, so you can install the version with your patch with pip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants