Merge pull request #32 from rally25rs/fix-yarn-pnp-29

fix #29 - use yarn to start node
rally25rs · Apr 19, 2024 · 8d3c734 · 8d3c734
2 parents 156e0c6 + 0e88b6f
commit 8d3c734
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 4 deletions.
diff --git a/.yarn/install-state.gz b/.yarn/install-state.gz
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+## Next Release
+
+- Fix #29 - Use `yarn` to start `node` in Docker image, so `yarn` can bootstrap `node` to load PnP dependencies.
+
 ## v0.2.0
 
 - Upgrade yarn from classic `v1` to modern `v4.0.2` (Used locally for build and test)

diff --git a/packages/k8s-when-ready-client/Dockerfile b/packages/k8s-when-ready-client/Dockerfile
@@ -10,4 +10,4 @@ RUN yarn workspaces focus --production
 COPY . /usr/src/app
 
 EXPOSE 3000
-ENTRYPOINT ["node", "index.js"]
+ENTRYPOINT ["yarn", "node", "index.js"]
diff --git a/packages/k8s-when-ready-client/package.json b/packages/k8s-when-ready-client/package.json
@@ -8,7 +8,7 @@
   "packageManager": "yarn@4.0.2",
   "scripts": {
     "test": "jest",
-    "build": "docker build ."
+    "build": "docker build . -t k8s-when-ready-client:latest"
   },
   "dependencies": {
     "yargs": "^17.7.2"

diff --git a/packages/k8s-when-ready-server/Dockerfile b/packages/k8s-when-ready-server/Dockerfile
@@ -10,4 +10,4 @@ RUN yarn workspaces focus --production
 COPY . /usr/src/app
 
 EXPOSE 3000
-ENTRYPOINT ["node", "index.js"]
+ENTRYPOINT ["yarn", "node", "index.js"]
diff --git a/packages/k8s-when-ready-server/package.json b/packages/k8s-when-ready-server/package.json
@@ -8,7 +8,7 @@
   "packageManager": "yarn@4.0.2",
   "scripts": {
     "test": "jest",
-    "build": "docker build ."
+    "build": "docker build . -t k8s-when-ready-server:latest"
   },
   "dependencies": {
     "@kubernetes/client-node": "^0.20.0",