Fix out of bounds std::vector subscript operator usage #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In several places, the std::vector subscript operator[] is used together with the addressof operator to obtain a pointer into the vector. In some cases, this is intended to yield a pointer past the end of the vector. In such cases, the pointer is not actually used to read from or write to. Thus it causes no actual problems in practice and even address sanitizer and valgrind are happy with it. However, operator[] is still called with an out of bounds index, which is undefined behaviour. This is correctly detected by Microsofts standard library debug checks and also by GNU's library once compiling with -D_GLIBCXX_DEBUG. As a fix, we use .data() and pointer arithmetic to get to the intended pointer without any out of bound access. Fixes ralna#140
|
Many thanks @mjacobse this looks great to me! |
jfowkes
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #140. This was the minimum amount of replacements with
.data()that causes no errors with-D_GLIBCXX_DEBUGfor me across all tests.