Add Mac CI tests

[jfowkes]

We should also automatically test SPRAL on Mac.

[amontoison]

@jfowkes, I found this today, it could be relevant for SPRAL (and GALAHAD): https://gist.github.com/scivision/d94bb10a01fa3b8ed0c9a93ee16318ba

[jfowkes]

@amontoison great will add an Intel test script!

[jfowkes]

@amontoison also what is your FC when compiling with Clang on Mac?

[amontoison]

It's gfortran in the cross-compiler.

[jfowkes]

@amontoison ok will switch the workflow to gfortran, flang is still experimental...

[jfowkes]

Now we're getting a legitimate C++ compiler failure:

./src/ssids/cpu/kernels/assemble.hxx:230:35: error: no matching constructor for initialization of 'std::vector<int, PoolAllocInt>' (aka 'vector<int, BuddyAllocator<int, std::allocator<double>>>')
   std::vector<int, PoolAllocInt> map(n+1, PoolAllocInt(pool_alloc));
                                  ^   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

@nimgould do you also run into this compiler failure with Clang?

[nimgould]

On 11/14/22 09:06, Jari wrote: Now we're getting a legitimate C++ compiler failure: |./src/ssids/cpu/kernels/assemble.hxx:230:35: error: no matching constructor for initialization of 'std::vector<int, PoolAllocInt>' (aka 'vector<int, BuddyAllocator<int, std::allocator<double>>>') std::vector<int, PoolAllocInt> map(n+1, PoolAllocInt(pool_alloc)); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | @nimgould <https://github.com/nimgould> do you also run into this compiler failure with Clang? — Reply to this email directly, view it on GitHub <#97 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACW4A6UUUEACHXVNX6QFAU3WIH6KZANCNFSM6AAAAAAR4KU2LE>. You are receiving this because you were mentioned.Message ID: ***@***.***>

Nope, it complies without issues with clang (the compiled version that supports flang). How odd

…

-- Nicholas I. M. Gould Scientific Computing Department email: ***@***.*** G39, R71 Rutherford Appleton Laboratory phone: 0(44)1235 445801 Chilton, Oxon OX11 0QX England EU www: http://www.numerical.rl.ac.uk/people/nimg This email and any attachments are intended solely for the use of the named recipients. If you are not the intended recipient you must not use, disclose, copy or distribute this email or any of its attachments and should notify the sender immediately and delete this email from your system. UK Research and Innovation (UKRI) has taken every reasonable precaution to minimise risk of this email or any attachments containing viruses or malware but the recipient should carry out its own virus and malware checks before opening the attachments. UKRI does not accept any liability for any losses or damages which the recipient may sustain due to presence of any viruses.

[jfowkes]

Looking at the error further, it appears that Clang can't find the C++ standard library vector implementation, which suggests an issue with finding the C++ standard library headers.

[nimgould]

Yes, the flang Linux archdefs file has the flag component SOMP = -fopenmp=libomp -I/usr/lib/llvm-14/lib/clang/14.0.0/include which is not portable, but makes good things happen. I presume that Macs will have some other non-portable location

…

-- Nicholas I. M. Gould Scientific Computing Department email: ***@***.*** G39, R71 Rutherford Appleton Laboratory phone: 0(44)1235 445801 Chilton, Oxon OX11 0QX England EU www: http://www.numerical.rl.ac.uk/people/nimg This email and any attachments are intended solely for the use of the named recipients. If you are not the intended recipient you must not use, disclose, copy or distribute this email or any of its attachments and should notify the sender immediately and delete this email from your system. UK Research and Innovation (UKRI) has taken every reasonable precaution to minimise risk of this email or any attachments containing viruses or malware but the recipient should carry out its own virus and malware checks before opening the attachments. UKRI does not accept any liability for any losses or damages which the recipient may sustain due to presence of any viruses.

[amontoison]

@jfowkes
LLVM projects use -lc++ and not -lstdc++.
Maybe you just need to update these lines: https://github.com/ralna/spral/blob/master/configure.ac#L70-L78

[jfowkes]

@amontoison ahh yes you are right, that should do the trick!

[jfowkes]

@amontoison sadly that didn't seem to work, unfortunately I don't understand autotools enough to know if I'm doing it correctly or even if CXXLIB is being picked up anywhere.

[amontoison]

Can you test with clang++ from Homebrew?
https://stackoverflow.com/questions/70168181/apple-clang-13-c20-module-support-missing

[jfowkes]

I have tried with $(brew --prefix llvm@14)/bin/clang as suggested by the docs here:
https://github.com/actions/runner-images/blob/releases/macOS-11/20221028/images/macos/macos-11-Readme.md
However then configure is unable to find Metis for some reason.

[amontoison]

Ok, let's try again with the flag -stdlib=libc++ instead of -lc++.

[jfowkes]

@amontoison no joy, -stdlib=libc++ is the default anyway and should not be required.

[amontoison]

Hum, I don't know how to solve this issue.
We should drop clang / clang++ for now and just compile with gcc / g++ on all platforms.

[dpo]

I don't think the problem is that std::vector is not available. The problem is that no std::vector constructor is found for the arguments given (Int and PoolAllocInt).

[dpo]

You're missing -std=c++14 from the C++ flags. The allocator construct used here is rather new.

After that, there are other compilation issues. After fiddling for a while, this incantation worked for me:

./configure CC=clang CXX=clang++ F77=gfortran-12 FC=gfortran-12 CFLAGS="-g -O2 -Wall -I$(brew --prefix openblas)/include" CXXFLAGS="-g -O2 -Wall -std=c++14 -I$(brew --prefix openblas)/include" FCFLAGS="-g -O2 -Wall -pedantic" LIBS="-lc++ -L$(brew --prefix openblas)/lib -lopenblas" --with-metis="-L$(brew --prefix metis)/lib -lmetis"

I decided to brew install openblas to work around an error where cblas.h was not found. Even though it is present in some obscure system header location, I could never get the compiler to find it.

After all that, make check works, but there's a failing ssids test:

PASS: lsmr_test
PASS: rutherford_boeing_test
PASS: scaling_test
PASS: random_test
PASS: random_matrix_test
./test-driver: line 112: 15120 Abort trap: 6           "$@" >> "$log_file" 2>&1
FAIL: ssids_test
PASS: ssids_kernel_test
PASS: ssmfe_test
PASS: ssmfe_ciface_test
============================================================================
Testsuite summary for spral 2021.09.01-dev
============================================================================
# TOTAL: 9
# PASS:  8
# SKIP:  0
# XFAIL: 0
# FAIL:  1
# XPASS: 0
# ERROR: 0

[dpo]

All is well if I replace clang and clang++ with gcc-12 and g++-12. All tests pass. That points to a bug in either the compiler, SSIDS or the SSIDS test.

[dpo]

This almost works with the Intel compilers:

./configure CC=icc CXX=icc F77=ifort FC=ifort CFLAGS="-g -O2 -Wall" CXXFLAGS="-g -O2 -Wall -std=c++14" FCFLAGS="-g -O2 -Wall -pedantic" LIBS=-lc++ HWLOC_CFLAGS="-I$(brew --prefix hwloc)/include" HWLOC_LIBS="-L$(brew --prefix hwloc)/lib -lhwloc" --with-blas="-L$MKLROOT/lib -lmkl_intel_lp64 -lmkl_sequential -lmkl_core -lpthread -lm" --with-lapack="-L$MKLROOT/lib -lmkl_intel_lp64 -lmkl_sequential -lmkl_core -lpthread -lm" --with-metis="-L$(brew --prefix metis)/lib -lmetis"

However, the -Wall flag isn't right, and during make check, the compiler can't find cblas.h. There doesn't seem to be one in the MKL, so I'm not sure what the solution is. Perhaps an additional define that would #include "mkl.h" (or whatever) instead of cblas.h if configuring --with-mkl for instance.

There are couple additional hoops to jump through related to Homebrew when building on Apple Silicon. (It's not the case of the GitHub VMs.) I can explain or write instructions at some point if you're interested.

It would be good if the workflows tested a variety of compilers, as those also serve as documentation and can help users get the incantation right.

[jfowkes]

@dpo thank you very much, that fixes the compilation issues!! Yeah finding C/C++ headers on modern macs is a real pain...

I will have a go later at creating macOS Intel CI tests, need to figure out the best way to install the Intel compilers (no apt on mac but probably pip is the easiest way). I assume that for your local tests you're sourcing /opt/intel/oneapi/setvars.sh to set up the Intel environment variables (including MKL). Btw it's -warn all for ifort (I presume for historical reasons).

I agree entirely that we should have proper CI tests for a variety of platforms and compilers. This has already shown us that SPRAL will only run correctly with gcc/gfortran as there are bugs when using all the other compilers.

[nimgould]

(To be honest, I don't see issues with spral under ifort/icc and ifx/icx on Linux). Maybe its my lucky day

[nimgould]

But, yes, CI on as many common platforms and compilers as possible

[jfowkes]

(To be honest, I don't see issues with spral under ifort/icc and ifx/icx on Linux). Maybe its my lucky day

@nimgould yes the issue with Intel on Linux is a sefgault with SSMFE (see #98)

[dpo]

need to figure out the best way to install the Intel compilers (no apt on mac but probably pip is the easiest way).

See my SIFDecode/CUTEst/GALAHAD workflow where I install the Intel compilers using the "official" way.

[jfowkes]

Superseded by #113