Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: validate form #27

Merged
merged 2 commits into from
Oct 2, 2021

Conversation

Roms1383
Copy link
Contributor

Hi everybody, this PR :

  • implements Form and FormConfig
  • add tests
  • add documentation

It follows the same implementation pattern as per the other structs (Json, JsonConfig and so on).
:)

implement Form and FormConfig + tests + doc
@AndreyErmilov
Copy link
Collaborator

Thanks! Great work! 👍
Update readme please!

@Roms1383
Copy link
Contributor Author

Done, thanks :)

@Roms1383
Copy link
Contributor Author

anything missing @AndreyErmilov?

@Roms1383
Copy link
Contributor Author

Roms1383 commented Oct 2, 2021

Could you please give me some update on this @AndreyErmilov ?

@AndreyErmilov
Copy link
Collaborator

@Roms1383 Thank you, everything is great!
We plan to finalize this PR and make a new release in the near future.

@AndreyErmilov AndreyErmilov merged commit 06e839e into rambler-digital-solutions:master Oct 2, 2021
@singulared
Copy link
Collaborator

@Roms1383 Released in 2.2.0

@Roms1383 Roms1383 deleted the feat/form branch October 19, 2021 04:37
@Roms1383
Copy link
Contributor Author

@AndreyErmilov @singulared sorry for not getting back to you before, I often don't get the Github notifications.
Thanks for accepting the PR and, as a side note, I'm actively tracking next version of actix so I'll probably push a PR when they get out of beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants