Set empty bytestring as default for tags #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm a bit puzzled about the pipeline failure but it seems similar to an issue I had with testing locally (need to run |
|
Thanks a lot! I have some ideas about your PR. And anyway, I should fix the test issue. |
singulared
reviewed
Apr 19, 2019
|
Added in 0.2.0 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using links and not adding an explicit tag to the link entry, the library will default to using an empty string, whilst the protobuf package validates that this is a bytestring. This pull request adds two tests for adding links with explicit tags and without and changes the default link tag to an empty bytestring.