Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove functions deprecated in v0.14.0 #1112

Merged
merged 1 commit into from
May 26, 2015

Conversation

davidchambers
Copy link
Member

I'm sad to see R.isNaN go. 😢

@CrossEye
Copy link
Member

I don't even remember the deprecation of mean and median... although I remember when they were added and didn't see them as crucial at the time...

@davidchambers
Copy link
Member Author

This pull request only removes R.isNaN. Several files made use of this function, so this pull request replaces occurrences of R.isNaN with R.identical(NaN).

@CrossEye
Copy link
Member

Yeah, I had a weird afternoon with GitHub. A number of pages were jumbled. I seemed to have misread a number of things, on Ramda and several other projects. Sorry about that.

@davidchambers
Copy link
Member Author

:herb:?

buzzdecafe added a commit that referenced this pull request May 26, 2015
remove functions deprecated in v0.14.0
@buzzdecafe buzzdecafe merged commit 512826b into ramda:master May 26, 2015
@davidchambers davidchambers deleted the deprecated branch May 26, 2015 23:43
@CrossEye
Copy link
Member

Oh, yes, and 🌿

Sorry, got distracted. Really gotta find me a new emoji, too. 😄

lo1tuma added a commit to lo1tuma/ramda that referenced this pull request Dec 28, 2015
The examples for `R.none` still used `R.isNaN` which was removed in ramda#1112.
I’ve replace the examples with actual use-cases from the tests.
lo1tuma added a commit to lo1tuma/ramda that referenced this pull request Dec 28, 2015
The examples for `R.none` are still using `R.isNaN` which was removed in ramda#1112.
I’ve replace the examples with actual use-cases from the tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants