Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/end2end-calibration-tests #1

Merged
merged 14 commits into from
Dec 8, 2021
Merged

feature/end2end-calibration-tests #1

merged 14 commits into from
Dec 8, 2021

Conversation

BAILOOL
Copy link
Collaborator

@BAILOOL BAILOOL commented Dec 3, 2021 •
edited
Loading

Summary of this PR:

  • introduces end2end-calibration tests
  • fixes memory leaks (all memory leaks are resolved)
  • robustifies code to be more thread-safe
  • improves documentation

@BAILOOL BAILOOL added the enhancement New feature or request label Dec 3, 2021
@BAILOOL BAILOOL self-assigned this Dec 3, 2021
@BAILOOL BAILOOL marked this pull request as ready for review December 6, 2021 12:19
rameau-fr
rameau-fr approved these changes Dec 7, 2021
View reviewed changes
.gitignore Show resolved Hide resolved
src/Camera.cpp Show resolved Hide resolved
src/Camera.cpp Show resolved Hide resolved
src/CameraGroup.hpp Show resolved Hide resolved
src/CameraGroupObs.cpp Show resolved Hide resolved
@BAILOOL BAILOOL merged commit a7b1c2c into master Dec 8, 2021
@BAILOOL BAILOOL deleted the feature/end2end-calibration-tests branch December 8, 2021 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rameau-fr rameau-fr rameau-fr approved these changes

@zzangjinsun zzangjinsun zzangjinsun approved these changes

Assignees

@BAILOOL BAILOOL

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BAILOOL @zzangjinsun @rameau-fr